Use "close factor" of 0.00001 everywhere. - #16
Open
kblaschke wants to merge 2 commits into
Open
Conversation
revmischa
approved these changes
Mar 5, 2026
Member
Author
|
Thanks for reviewing! I'll merge the branch when I'm back home in about two weeks. No hurry here. |
Testing has shown that this is the actual value used in ns-eel2 in all cases.
kblaschke
force-pushed
the
fix-equality-factor
branch
from
August 3, 2026 17:32
1ddb2f7 to
8d564cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing has shown that this is the actual value used in ns-eel2 in all cases.
Fixes presets like
Stahlregen - Paint (Proof of Concept 2)using theequal()function (or the==operator) and possibly many others in more or less subtle ways.